Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit write performance improvement #388

Closed
miloszm opened this issue Sep 30, 2024 · 0 comments
Closed

Commit write performance improvement #388

miloszm opened this issue Sep 30, 2024 · 0 comments
Assignees
Labels
type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)

Comments

@miloszm
Copy link
Contributor

miloszm commented Sep 30, 2024

Summary

Commit command returns commit which is used only for root calculation, this is sub-optimal as it increases commit persistence time by ca 20% because of extra commit clone and extra retrieval which can be avoided. Similarly, when storing index, converting its serialised form to vector is not needed and also costs ca 15% of time.

Possible solution design or implementation

From Commit command, pass back hash rather than entire commit, do not retrieve commit, and do not convert serialised index to an extra vector.

@miloszm miloszm self-assigned this Sep 30, 2024
@miloszm miloszm changed the title Improve commit write optimization Commit write performance improvement Sep 30, 2024
@HDauven HDauven added the type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) label Sep 30, 2024
@HDauven HDauven closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Development

No branches or pull requests

2 participants