You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using coalesce or querying multiple values for a key, EDA and its ancestors encode the query parameters as such (à la PHP/Rails):
?ids[]=1&ids[]=2&ids[]=3
Out of the box, DRF can handle this:
?id=1&id=2&id=3
Would need to change this for coalesced .find as well as .query (it looks like they live in two separate places in upstream code).
Could this be fixed on the server end? Yes, but it seems to me that if I'm going to modify Django's handling, I would use a JSON-API renderer/parser on the server side as well. If I'm using EDA, I'd like to be able to use DRF out of the box.
I'd be interested in tackling this, but before I dive in I want to make sure there's not a use case I'm missing.
The text was updated successfully, but these errors were encountered:
Great suggestion. I'd certainly be interested in a pull request from you. As you probably know, we currently suggest a server-side DRF filter to support this; but I see no reason or "use case" that warrants continued recommendation of this method. Out-of-the-box support would be much better.
When using coalesce or querying multiple values for a key, EDA and its ancestors encode the query parameters as such (à la PHP/Rails):
?ids[]=1&ids[]=2&ids[]=3
Out of the box, DRF can handle this:
?id=1&id=2&id=3
Would need to change this for coalesced .find as well as .query (it looks like they live in two separate places in upstream code).
Could this be fixed on the server end? Yes, but it seems to me that if I'm going to modify Django's handling, I would use a JSON-API renderer/parser on the server side as well. If I'm using EDA, I'd like to be able to use DRF out of the box.
I'd be interested in tackling this, but before I dive in I want to make sure there's not a use case I'm missing.
The text was updated successfully, but these errors were encountered: