Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_widget does not honor max_cols #21

Open
xmikew opened this issue Jul 29, 2013 · 2 comments
Open

add_widget does not honor max_cols #21

xmikew opened this issue Jul 29, 2013 · 2 comments

Comments

@xmikew
Copy link

xmikew commented Jul 29, 2013

http://jsfiddle.net/mKKXz/2/

create grid with max_col 1.
Click 'add widget' a couple of times. Notice that the widgets will be added in columns that exceed max_cols. You won't be able to swap a widgets if they are in a col < max_col with one that >= max_col but you can move the widgets that are in the invalid cols to the ones that are in the col.

See jsfiddle for examples.

@xmikew
Copy link
Author

xmikew commented Jul 30, 2013

Not extremely familiar with the code, and not setup to run unit tests but here's a potential fix.

https://github.com/xmikew/gridster.js/commit/372db2b11a6fd4a26e61b0115b64d3efda426970

In my limited use case, seems to work alright.

- Mike

@mobweb
Copy link

mobweb commented Jun 21, 2016

@xmikew: Your fix is giving a 404, any chance you could share it? Because I have exactly the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants