Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misalignment in index due to nissing cuda ctream parameter in vision embed_image #5

Open
fan-chao opened this issue Dec 20, 2024 · 0 comments

Comments

@fan-chao
Copy link

A bug was discovered during testing in the scan functionality. In nanodb.py at line 253, the vision model was not being passed a cuda stream parameter, which led to data misalignment during cuda synchronization. This resulted in incorrect final index data.

The corrected code is as follows:
embedding = self.model.vision.embed_image(data, stream=self.model.stream)

This modification ensures that the stream attribute of the model is correctly passed to the embed_image method, maintaining data integrity during the synchronization process and ensuring accurate index data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant