Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can you apply nn.linear in upsampling #64

Open
LEEHK96 opened this issue Oct 17, 2022 · 1 comment
Open

How can you apply nn.linear in upsampling #64

LEEHK96 opened this issue Oct 17, 2022 · 1 comment

Comments

@LEEHK96
Copy link

LEEHK96 commented Oct 17, 2022

In TransitionUp layer, I just wonder one thing, but I have no idea.

x = self.linear1(x1) + pointops.interpolation(p2, p1, self.linear2(x2), o2, o1)

as you mentioned earlier in different issue, I know what offset do but,

As far as I understand, I think we should divide the number of points per batch in x_2 and apply linear respectively.

like in your work,

> if pxo2 is None:
>             _, x, o = pxo1  # (n, 3), (n, c), (b)
>             x_tmp = []
>             for i in range(o.shape[0]): ....
> 

so I wonder how it can be done at once.

I think self.linear2(x2) will combine all points in different data.

If you think I'm wrong, please let me know. Thank you!

and Thank you for great work!

@X-Lai
Copy link
Collaborator

X-Lai commented Oct 18, 2022

I don't really understand your problem. Butx2 contains features for different scenes in the same batch, and all of them share the same linear transformation. I think this is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants