Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive previous version when tags are separated with another tag #104

Merged
merged 1 commit into from
May 30, 2019
Merged

Derive previous version when tags are separated with another tag #104

merged 1 commit into from
May 30, 2019

Conversation

2m
Copy link
Member

@2m 2m commented May 29, 2019

Currently all tags are considered in git describe for previous version derivation. However if git describe returns non-version tag, it is not parsed successfully and the previous version is None.

This PR makes the git describe command consider only tags starting with v for previous version derivation.

dwijnand
dwijnand approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks. I remember noticing some differences between the two commands and wondering, at some point.

@2m 2m force-pushed the wip-unrelated-tags-2m branch from 14d49f2 to d4bc6d2 Compare May 30, 2019 06:35
@dwijnand dwijnand merged commit e1158d4 into sbt:master May 30, 2019
@2m 2m deleted the wip-unrelated-tags-2m branch June 18, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2m @dwijnand