Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the requirements.txt instead of hardcoding the version of ansible? #69

Open
zoobab opened this issue Nov 7, 2018 · 1 comment
Open

Comments

@zoobab
Copy link
Contributor

zoobab commented Nov 7, 2018

In the following section of install-from-bastion.sh, you specify by hand which version of ansible to use, which is different by version of openshift-ansible:

# Get the OpenShift 3.10 installer.
pip install -I ansible==2.6.5
git clone -b release-3.10 https://github.com/openshift/openshift-ansible

# Get the OpenShift 3.9 installer.
# pip install -I ansible==2.4.3.0
# git clone -b release-3.9 https://github.com/openshift/openshift-ansible

# Get the OpenShift 3.7 installer.
# pip install -Iv ansible==2.4.1.0
# git clone -b release-3.7 https://github.com/openshift/openshift-ansible

# Get the OpenShift 3.6 installer.
# pip install -Iv ansible==2.3.0.0
# git clone -b release-3.6 https://github.com/openshift/openshift-ansible

Would not it be better to use at least the requirements.txt shipped with openshift-ansible? And even further, in a venv.

@dwmkerr
Copy link
Owner

dwmkerr commented Nov 9, 2018

Agreed, sounds more sensible. I'll take a look into this once I look at 3.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants