Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-fixing Checklist ? #14

Open
nelsonic opened this issue Sep 11, 2016 · 1 comment
Open

Bug-fixing Checklist ? #14

nelsonic opened this issue Sep 11, 2016 · 1 comment

Comments

@nelsonic
Copy link
Member

nelsonic commented Sep 11, 2016

Often I come across code in a "mature" codebase that I have no idea how it got there.
image

should we add a section on bug-fixing encouraging (requiring?) people to:

  • add a code comment linking to a bug report in the code...?
  • create a regression test with a clear and link to the github issue that unambiguously fixes the issue.
@iteles
Copy link
Member

iteles commented Sep 11, 2016

I really like the idea. The question is should this be for all bugs or only the code that is maybe a little out of place or we think new developers to the code wouldn't fully understand the thinking behind?

I can imagine that some code bases would be FULL of comments if this goes on over the course of a year or two. Not sure that's an issue.

@nelsonic nelsonic changed the title When Bug-fixing Should we add Comments Link to a Specific Bug ? Bug-fixing Checklist ? Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants