Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a PR, removing 'in-progress' label: Remove self-assignment from issue too? #89

Open
mk4111 opened this issue Feb 15, 2017 · 4 comments

Comments

@mk4111
Copy link
Member

mk4111 commented Feb 15, 2017

When we work on an issue, the first thing we do (upon getting the green light to actually work on the issue), is a) assigning oneself to the task/issue and b) sticking the 'in-progress' label on.

When we are done working on the issue, and have made a PR, we assign the PR to another person to review, and we also remove the 'in-progress' label from the issue, but do we also remove ourselves from 'Assignees'?

@ghost
Copy link

ghost commented Feb 15, 2017

@mk4111 yes I believe so, then if the PR requires changes the reviewer assigns you back on - @nelsonic and I are going over the contributing guide tomorrow afternoon to help make it easier to read and understand

@mk4111
Copy link
Member Author

mk4111 commented Feb 17, 2017

@markwilliamfirth - cool! Thank you! I'll close this issue once I've had a read of the update!! Hope that's ok! :)

@mk4111
Copy link
Member Author

mk4111 commented Mar 8, 2017

Hi @markwilliamfirth! Forgive me if I'm being a bit of a Humpty Dumpty and it's already been updated, but can you let me know if/when the README gets updated so I can be sure to check it out and close this issue? Thank you!

@ghost
Copy link

ghost commented Mar 8, 2017

It hasn't been updated yet - it got pushed back :(
I'll update here when it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant