Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should/shouldn't javascript be used across the site? #317

Closed
Cleop opened this issue Sep 13, 2017 · 3 comments
Closed

How should/shouldn't javascript be used across the site? #317

Cleop opened this issue Sep 13, 2017 · 3 comments
Assignees
Labels
help wanted If you can help make progress with this issue, please comment! question A question needs to be answered before progress can be made on this issue
Milestone

Comments

@Cleop
Copy link
Member

Cleop commented Sep 13, 2017

So far with the site redesign I've been working using the simplest solutions where possible. I know that not using js has accessibility advantages and we chose not to use it for creating the burger menu where there was a feasible non js alternative available.

Now working on the team page I've tried to follow this avoidance of js which is looking to be possible. However my concern is with the state of the code without it. The team page is almost 600 lines long and now I need to add an adjustment to make my existing working version match the designs more closely: #283 (comment)

I can foresee making this change to each of the 28 team members taking a while and increasing our already long file by another 150 lines of code. Before I plough ahead and do this I wanted to check in to see whether this non js ethos was to be applied across the entire site and if not, on which occasions we're happy to use js? The other alternative of course is to alter the designs which don't have to require this behaviour.

This is what we get without the extra work:

image

The extra work is to not push other team members down so the description sits on top of them and also to create a border around the whole of the card.

I think this issue somewhat depends on when #270 is put into play as well. They're both questions of - do we do what is fastest or simplest or when do we scale up more?

@Cleop Cleop added help wanted If you can help make progress with this issue, please comment! question A question needs to be answered before progress can be made on this issue labels Sep 13, 2017
@Cleop Cleop added this to the Sprint 1 milestone Sep 13, 2017
@Cleop Cleop assigned iteles and ghost Sep 13, 2017
@iteles
Copy link
Member

iteles commented Sep 14, 2017

@Cleop Happy to use JavaScript to enhance the UX, but it must gracefully degrade to what you have above when JS is switched off 👍
The important thing is that if JS is useful to make things clearer for the person viewing the site, a non-JS fallback must exist.

@iteles iteles assigned Cleop and unassigned iteles and ghost Sep 14, 2017
@iteles
Copy link
Member

iteles commented Sep 14, 2017

It's worth flagging in the issue when JS is proposed (as you have now) going forward @Cleop 👍

@Cleop
Copy link
Member Author

Cleop commented Sep 15, 2017

Closing as answer provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted If you can help make progress with this issue, please comment! question A question needs to be answered before progress can be made on this issue
Projects
None yet
Development

No branches or pull requests

2 participants