Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract selenium install logic to a specific module #55

Open
Sergeon opened this issue Feb 5, 2017 · 0 comments
Open

Extract selenium install logic to a specific module #55

Sergeon opened this issue Feb 5, 2017 · 0 comments

Comments

@Sergeon
Copy link

Sergeon commented Feb 5, 2017

Currently, the whole nightwatch.conf.js is set as a postinstall hook in package.json. But the only reason to do that -as far as I understand- is to ensure that selenium gets downloaded. This is pretty misleading since people just copypasting the configuration object from nightwatch.conf.js to their own config file as a template would not get the tests to run, since selenium would not be downloaded.

Also, this way is just more clear what the postinstall hook is about, and concerns are better separated between the nightwatch configuration and the selenium install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants