Skip to content

Commit

Permalink
adds clarifying comment to player.js explaining that we prefer Elm as…
Browse files Browse the repository at this point in the history
… noted by @des-des in #42 (review)
  • Loading branch information
nelsonic committed Mar 6, 2017
1 parent b0ea31b commit cfe5333
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions rumbl/web/static/js/player.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
let Player = {
player: null,

let Player = { // JS works for small scripts like this
player: null, // but for anything bigger we prefer Elm
// and so do the creators of Phoenix!
// see: https://github.com/dwyl/learn-elm
init(domId, playerId, onReady) {
window.onYouTubeIframeAPIReady = () => {
this.onIFrameReady(domId, playerId, onReady)
Expand Down

0 comments on commit cfe5333

Please sign in to comment.