Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This article isn't really geared for Phoenix 1.4? #19

Closed
ericchuawc opened this issue Feb 7, 2019 · 3 comments
Closed

This article isn't really geared for Phoenix 1.4? #19

ericchuawc opened this issue Feb 7, 2019 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ericchuawc
Copy link

Just my personal feedback.

As it is stated it will be based on Phoenix 1.4, some parts are not so applicable

Examples

npm install in assets folder, believed this is no longer valid as phoneix 1.4 is using webpack and npm install will work when you setup the project for the 1st time

also phoenix 1.4 is using milligram, so the codes in index.html.eex will not display properly as the codes are based on bootstrap related.

Hope you can enhance it or have a change notes somewhere. It will help the beginners to phoenix 1.4.

@ericchuawc ericchuawc changed the title Doesn't really work with Phoenix 1.4? This article isn't really geared for Phoenix 1.4? Feb 7, 2019
@nelsonic
Copy link
Member

nelsonic commented Feb 7, 2019

@ericchuawc thank you for your feedback. ❤️
We would gladly accept a pull request with any updates
which you feel are relevant to make the example more applicable to Phoenix v.1.4

@nelsonic nelsonic added bug Something isn't working help wanted Extra attention is needed labels Feb 7, 2019
@KanagawaMarcos
Copy link

I've noticed bugs as well, mainly due to the bootstrap change. I'll fix it an send a pull request as soon as I can.

@nelsonic
Copy link
Member

Long since updated to Phoenix 1.5.5 #48 with complete review.
Update to 1.6 on Todo List for soon. #55
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants