Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still some errors in instructions? #123

Open
layeddie opened this issue Mar 21, 2023 · 3 comments
Open

Still some errors in instructions? #123

layeddie opened this issue Mar 21, 2023 · 3 comments
Assignees
Labels
elixir Pull requests that update Elixir code help wanted If you can help make progress with this issue, please comment! T25m Time Estimate 25 Minutes tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@layeddie
Copy link

layeddie commented Mar 21, 2023

Sorry - not chasing but just tried this again as I noticed some updates.
My setup

❯ elixir -v
Erlang/OTP 25 [erts-13.0] [source] [64-bit] [smp:12:12] [ds:12:12:10] [async-threads:1] [jit]

Elixir 1.14.3 (compiled with Erlang/OTP 25)

~/projects/2023/examples/phoenix-liveview-chat-example main                                               13:47:56
❯ mix phx.new --version
Phoenix installer v1.7.1

git clone (https://github.com/dwyl/phoenix-liveview-chat-example.git)

Worked fine.

When I tried to build via the instructions I got some errors after section 2 and 3...
Looked over the instructions a few times to see if I had made some mistakes.
I have tried (https://github.com/dwyl/phoenix-chat-example) (I meant the git cloned app on my machine)

== Compilation error in file lib/liveview_chat_web/views/message_view.ex ==
** (UndefinedFunctionError) function LiveviewChatWeb.view/0 is undefined or private
    (liveview_chat 0.1.0) LiveviewChatWeb.view()
    (liveview_chat 0.1.0) expanding macro: LiveviewChatWeb.__using__/1
    lib/liveview_chat_web/views/message_view.ex:2: LiveviewChatWeb.MessageView (module)
    (elixir 1.14.3) expanding macro: Kernel.use/2
    lib/liveview_chat_web/views/message_view.ex:2: LiveviewChatWeb.MessageView (module)
Compiling 1 file (.ex)
@nelsonic nelsonic added help wanted If you can help make progress with this issue, please comment! elixir Pull requests that update Elixir code tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies labels Mar 23, 2023
@nelsonic
Copy link
Member

@SimonLab if you have time, please go through these errors in the instructions & update. 🙏

@nelsonic nelsonic added the T25m Time Estimate 25 Minutes label Jul 22, 2023
@chargio
Copy link

chargio commented Oct 19, 2023

Hi,

I've created a version of this (up to the broadcast of messages), that works with LiveView 0.20.1
https://github.com/chargio/liveview_chat

@SimonLab It would be great if you can have a view at the code, I will create a PR with the new code if it is ok, but I need to clean up the code, and rewrite a lot of instructions, and I want to make sure that it makes sense to do it and that the PR will be accepted.

It uses the stream from Liveview 0.20, so some of the code is not needed, and I am not a good designer, so I haven't changed the interface (I am using a table generated by phx.gen.live)

Let me know if it is worth it.

@nelsonic
Copy link
Member

A PR that simplifies code and reduces the number of steps in the instructions is always welcome! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code help wanted If you can help make progress with this issue, please comment! T25m Time Estimate 25 Minutes tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Development

No branches or pull requests

4 participants