Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for #7 don't pass #8

Closed
th0mas opened this issue Sep 15, 2020 · 4 comments
Closed

Tests for #7 don't pass #8

th0mas opened this issue Sep 15, 2020 · 4 comments

Comments

@th0mas
Copy link
Collaborator

th0mas commented Sep 15, 2020

When attempting to refractor some code for #7, I ran the test suite to make sure my development environment worked. However, I can't get one of the tests to pass without changing any code:

image

@th0mas
Copy link
Collaborator Author

th0mas commented Sep 15, 2020

Don't seem to pass on Travis either now:

image

@nelsonic
Copy link
Member

@th0mas good catch. the length should be 8 unless the app associated has custom roles.
I was using my AUTH_API_KEY for an app that had 9 roles to confirm that a custom role is retrieved. 👍

@th0mas
Copy link
Collaborator Author

th0mas commented Sep 15, 2020

Fixed now...?

@th0mas th0mas closed this as completed Sep 15, 2020
@nelsonic
Copy link
Member

@th0mas I created a custom role for the App to confirm.
Don't worry, it's not an intermittent failure.
But it will be "brittle" until we restrict CRUD access to roles (as you have already pointed out) dwyl/auth#116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants