Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client_metadata no longer able to pass custom value #289

Open
sergulec opened this issue Nov 14, 2024 · 4 comments
Open

client_metadata no longer able to pass custom value #289

sergulec opened this issue Nov 14, 2024 · 4 comments

Comments

@sergulec
Copy link

sergulec commented Nov 14, 2024

Hi, before the most recent update I was passing client_metadata a value . Its now being populated based on order type. Is it possible to inject some values or use another field that will flow into the fill message with custom values (maybe clientId)? My attempt was to change market.Order to take a dictionary for client_metadata but this seems to still get overwritten when fill message comes.
The change was in this commit ee71838
Thanks

Copy link

linear bot commented Nov 14, 2024

@samtin0x
Copy link
Contributor

Hi @sergulec, the change was implemented to track usage consistently across both the deprecated and newer Python clients, as well as the JS/TS and Rust clients. Its purpose is to monitor and analyze client behavior, helping understand how the various implementations are being utilized.

Do you have a specific use case so it can be reconsidered adding back custom client_metadata values?

@sergulec
Copy link
Author

sergulec commented Jan 5, 2025

Hi @sergulec, the change was implemented to track usage consistently across both the deprecated and newer Python clients, as well as the JS/TS and Rust clients. Its purpose is to monitor and analyze client behavior, helping understand how the various implementations are being utilized.

Do you have a specific use case so it can be reconsidered adding back custom client_metadata values?

I was using it to add some data from time of the trade , after some thought its probably not the right place for it as it can be tracked on the client side off the clientId.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants
@sergulec @samtin0x and others