libraries-test-suite: Stifle serious warnings

Some could be removed by fooling the compiler. Commented out a couple for
now. Perhaps we can reinstate test-ignorable and test-ignore when/if we have a
way to disable compiler warnings for a swath of code.

Author: cgay

sources/common-dylan/tests/common-extensions-tests.dylan

@@ -150,6 +150,11 @@ define test test-find-element ()
                      skip: 2), #f);
 end test;
 
+/*
+Commenting these two out for now because they cause serious warnings. We want
+to be able to run libraries-test-suite from the GitHub CI and have serious
+warnings cause a failure. --cgay 2022
+
 define test test-ignorable ()
   assert-signals(<error>, ignorable(this-is-undefined),
                  "ignorable crashes on undefined variables");
@@ -159,6 +164,7 @@ define test test-ignore ()
   assert-signals(<error>, ignore(this-is-undefined),
                  "ignore crashes on undefined variables");
 end;
+*/
 
 define test test-one-of ()
   let new-type = #f;
@@ -503,8 +509,8 @@ define suite common-extensions-test-suite ()
   test test-difference;
   test test-false-or;
   test test-find-element;
-  test test-ignorable;
-  test test-ignore;
+  //test test-ignorable;
+  //test test-ignore;
   test test-one-of;
   test test-position;
   test test-split;

sources/dylan/tests/control.dylan

@@ -73,20 +73,26 @@ define test test-conditionals ()
 	      #(9, 8, 7));
 end test;
 
-define function no-param-function () 1 end;
-define function one-param-function (x) x end;
-
 define test test-required-calls (expected-failure?: #t)
   check-equal("no param call",
               (method () 1 end)(), 1);
   check-equal("one param call one arg",
               (method (x) x end)(1), 1);
+
+  // Defeat compiler warnings. We want to check runtime errors.
+  local method fun0 () 1 end;
+  let no-param-function = list(fun0)[0];
   check-condition("no param call one arg", <error>,
                   apply(no-param-function, #[1]));
+
+  // Defeat compiler warnings. We want to check runtime errors.
+  local method fun1 (x) x end;
+  let one-param-function = list(fun1)[0];
   check-condition("one param call no args", <error>,
                   apply(one-param-function, #[]));
   check-condition("one param call two args", <error>,
                   apply(one-param-function, #[1, 2]));
+
   check-equal("two args call",
               (method (x, y) x + y end)(1, 2), 3);
   check-equal("lots args call",

sources/dylan/tests/module.dylan

@@ -16,6 +16,7 @@ define module dylan-test-suite
               limited-integer-max };
   use common-dylan;
   use format;
+  use simple-random;
   use table-extensions,
     import: { case-insensitive-equal };
   use testworks;