Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tracing logger? #5

Open
WindSoilder opened this issue Jan 23, 2024 · 3 comments
Open

Support tracing logger? #5

WindSoilder opened this issue Jan 23, 2024 · 3 comments

Comments

@WindSoilder
Copy link

Hi, while reading example, I found that it uses log crate to initialize and log something.

I'm using tracing in application, and it seems that the log messages in python code doesn't show.

I don't want to introduce another log crate to my application, is there a way to make it work with tracing?

@dylanbstorey
Copy link
Owner

Hi, while reading example, I found that it uses log crate to initialize and log something.

I'm using tracing in application, and it seems that the log messages in python code doesn't show.

I don't want to introduce another log crate to my application, is there a way to make it work with tracing?

Yes that should be doable, im a bit busy atm but PRs are welcome.

@cpu
Copy link
Contributor

cpu commented Jul 23, 2024

FWIW I've been using this crate in an application that uses tracing through tracing-log. Thank you! It's a very helpful crate 🦀 ❤️ 🐍

Log messages from Python do appear in the expected place, with the correct level/message/source line number. The only foible in this setup I've observed is that the source file name is incorrect. PTAL at this branch for a fix that worked for me: #7

I'm not sure it's worth complicating this crate with tracing specific logic given the tracing-log crate exists and seems to work well out-of-box.

@dylanbstorey
Copy link
Owner

<3 to hear that !!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants