Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Google Sign Up doesn't work #7

Open
dylmye opened this issue Apr 9, 2023 · 1 comment
Open

[Bug]: Google Sign Up doesn't work #7

dylmye opened this issue Apr 9, 2023 · 1 comment
Labels
bug fix Fix me please

Comments

@dylmye
Copy link
Owner

dylmye commented Apr 9, 2023

Summary

Using the signup feature "sign up with google" causes firebase auth handler to freeze, sign in works as intended

Reproduction

  1. Visit lets plan fresh (no previous account)
  2. Click user menu > sign up
  3. Select Google

Expected

Just like with signing in, the auth popup closes and the user is brought back to their account where they are now logged in

Actual

The auth popup shows for an extended period before closing with an error: "Popup closed before sign up could complete".

Note that this doesn't happen for Google accounts that already have an account on Lets Plan, and doesn't happen at all when using "sign in with google" even for account new to Lets Plan

@dylmye dylmye added the bug fix Fix me please label Apr 9, 2023
@dylmye
Copy link
Owner Author

dylmye commented May 6, 2023

Can't reproduce with my account - the method for sign in and sign up is identical. Attempting to fix by closing modal after opening clicking on the signup button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fix me please
Projects
None yet
Development

No branches or pull requests

1 participant