Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libc dependency to 0.2.98 #6

Closed
mjturner opened this issue Jul 9, 2021 · 4 comments
Closed

Bump libc dependency to 0.2.98 #6

mjturner opened this issue Jul 9, 2021 · 4 comments
Labels
dependencies Issues caused by or affecting dependencies enhancement New feature or request

Comments

@mjturner
Copy link

mjturner commented Jul 9, 2021

I'm in the process of packaging Starship for NetBSD and recently ran into an issue similar to #4. It's been resolved in libc version 0.2.98 and process_control now works fine on NetBSD, at least for Starship's purposes.

Would it be possible to bump the libc dependency to version 0.2.98? This will make it a bit easier for us to build Starship on NetBSD as we'll no longer need to patch the build to do a local version override. Thanks!

@dylni
Copy link
Owner

dylni commented Jul 10, 2021

Yes, if bumping the minimum version makes your build easier, I can absolutely make that change.

Do you need the minimum version to be 0.2.98? From that issue, 0.2.88 (and possibly 0.2.87) should have support as well. I would rather avoid bumping libc to the latest version if possible, to avoid breaking builds or forcing a version that may be unusable for a project.

@mjturner
Copy link
Author

Great, thanks.

Unfortunately the fix for NetBSD is only in 0.2.98 and later (see #2265). I agree that bumping libc to the latest version does have some risk associated - I'd be happy if you want to hold off until the next release or the release after that, just to be safe. I can drop you a reminder if a few weeks, if that's ok?

@dylni dylni closed this as completed in 0752b93 Jul 14, 2021
@dylni
Copy link
Owner

dylni commented Jul 14, 2021

Thanks for the offer, but I decided to publish version 3.1.0 with the updated requirement. Since none of the published reverse-dependencies of libc have a version that forbids 0.2.98 but allows 0.2, this should be pretty safe. Any crates deciding later to add a maximum version for libc can add a maximum version for process_control too.

@mjturner
Copy link
Author

Brilliant, thanks!

@dylni dylni added enhancement New feature or request dependencies Issues caused by or affecting dependencies labels Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues caused by or affecting dependencies enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants