You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, there are two ways of enforcing stability in discovered models: StabilizedLinearSR3 and TrappingSR3. The latter requires two manual steps: adding constraints from the make_constraints function in example 8, and strengthening the default regularization $`/\eta$ from 1e-20 to something larger.
A few other issues I see:
Trapping largely follows the behavior of ConstrainedSR3, but inherits from SR3
Lots of repeated CVXPY code copied across SR3, ConstrainedSR3, and TrappingSR3
I am starting to slim down what TrappingSR3 does, offloading work to the superclass. This will make all the follow-on work easier. But before I do all this, I wanted to hear from @MPeng5 what your plans were as they relate to library design.
The text was updated successfully, but these errors were encountered:
@Jacob-Stevens-Haas Sorry Jacob, I was quite busy then but please let me join the discussion now. We come up with a new theorem which allows us to get rid of the make_constraints() in my version of Trapping. So let me know what your plan is right now. and as i mentioned from the other thread, we can discuss this on campus sometime.
Currently, there are two ways of enforcing stability in discovered models:$`/\eta$ from 1e-20 to something larger.
StabilizedLinearSR3
andTrappingSR3
. The latter requires two manual steps: adding constraints from themake_constraints
function in example 8, and strengthening the default regularizationA few other issues I see:
ConstrainedMixin
?I am starting to slim down what TrappingSR3 does, offloading work to the superclass. This will make all the follow-on work easier. But before I do all this, I wanted to hear from @MPeng5 what your plans were as they relate to library design.
The text was updated successfully, but these errors were encountered: