Issue 85 create required attributes on update #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- user can now choose whether or not to update timestamps specified with the 'timestamps' option (defined when making schema) on update.
Passing null or undefined for the key parameter in Model.update will now have it check default values for those keys before erroring out.
Conflicts: lib/Model.js
|
First -- Sorry for the delayed response. It looks great. The one thing I'm unsure about is What are your thoughts on changing the |
|
Setting it to |
Conflicts: lib/Model.js
- Table.js had a deferred rejection with just a string (changed to an error object) - updated model tests to reflect createRequired's default of false
|
Thanks a bunch for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is meant to address Issue #85. There is a lot going on here...
Model.updatenow has a new touch. If you pass anullorundefinedkey, then there is a check for key defaults. If the key attributes have defaults, those will be used. If they don't, then an error is thrown. This check is currently not in place.timestamps(as defined in the schema) are now updated by default. You can turn this behaviour off by:timestampsupdateTimestampsoption tofalseBut, most importantly, this PR now has the update also conditionally update required attributes. There is one catch though: required attributes that do not have a default value will throw an error on update if no value is provided for them.
I also added some tests for
Module.update