Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to nyc (istanbul) for unit test coverage #219

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Switch to nyc (istanbul) for unit test coverage #219

merged 1 commit into from
Oct 25, 2017

Conversation

lovell
Copy link
Contributor

@lovell lovell commented Oct 24, 2017

Hi Brandon, this is as discussed in #215

This PR uses current percentages as bare minimum threshold values, which can gradually be increased in line with coverage.

It also bumps mocha back to latest version that still provides support for Node 0.12.

Use existing coverage as threshold values

Bump mocha back to latest that supports Node 0.12
@brandongoode brandongoode merged commit 0d81bc6 into dynamoose:master Oct 25, 2017
@brandongoode
Copy link
Contributor

Thanks for the help.

@lovell lovell deleted the coverage-via-nyc branch October 25, 2017 18:48
@fishcharlie fishcharlie mentioned this pull request Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants