Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for PAY_PER_REQUEST BillingMode when Model includes Global Secondary Indexes #504

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

batmanppc
Copy link

Summary:

This PR fixes the option for ON_DEMAND throughput for creating tables using PAY_PER_REQUEST Billing Mode with Global Secondary Indexes.

Code sample:

Schema

var User = new dynamoose.Schema({
  id: Number,
  name: { type: String, index: { global: true } }
}, {
  throughput: "ON_DEMAND"
});

GitHub linked issue:

Closes #503

Type (select 1):

  • Bug fix
  • Feature implementation
  • Documentation improvement
  • Testing improvement
  • Test added to report bug (GitHub issue #--- @---)
  • Something not listed here

Is this a breaking change? (select 1):

  • 🚨 YES 🚨
  • No
  • I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

  • Yes
  • No

Are all the tests currently passing on this PR? (select 1):

  • Yes
  • No

Other:

  • I have searched through the GitHub pull requests to ensure this PR has not already been submitted
  • I have updated the Dynamoose documentation (if required) given the changes I made
  • I have added/updated the Dynamoose test cases (if required) given the changes I made
  • I have run npm test from the root of the project directory to ensure all tests continue to pass
  • I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
  • All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
  • I have confirmed that all my code changes are indented properly using 2 spaces
  • I have filled out all fields above

@coveralls
Copy link

coveralls commented Dec 12, 2018

Pull Request Test Coverage Report for Build 801

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 85.381%

Totals Coverage Status
Change from base Build 791: 0.04%
Covered Lines: 2147
Relevant Lines: 2438

💛 - Coveralls

Copy link
Member

@fishcharlie fishcharlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fishcharlie fishcharlie mentioned this pull request Dec 13, 2018
@fishcharlie fishcharlie merged commit 5248ea6 into dynamoose:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ON_DEMAND breaks table creation with global secondary index
3 participants