-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errorUnknown #531
errorUnknown #531
Conversation
errorUnknown
, when set to true, will throw an error if parseDynamo
encounters a record with a field at any level that is not specified in the Schema.
Pull Request Test Coverage Report for Build 838
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 838
💛 - Coveralls |
Pull Request Test Coverage Report for Build 838
💛 - Coveralls |
Pull Request Test Coverage Report for Build 849
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add this option to the documentation as well
Co-Authored-By: dobrynin <David.Dobrynin@gmail.com>
Co-Authored-By: dobrynin <David.Dobrynin@gmail.com>
@fishcharlie please take a look at the changes I pushed and my responses to your comments :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dobrynin Wait sorry. This needs documentation changes doesn't it? |
Good point. Added. |
Summary:
errorUnknown
, when set to true, will throw an error ifparseDynamo
encounters a record with a field at any level that is not specified in
the Schema.
Schema
General
If this record were encountered with the above schema, an error would be
thrown.
Type (select 1):
Is this a breaking change? (select 1):
Is this ready to be merged into Dynamoose? (select 1):
Are all the tests currently passing on this PR? (select 1):
Other:
npm test
from the root of the project directory to ensure all tests continue to pass