Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Filter field: Clear free text on lost focus #1572

Closed
OFouda opened this issue Sep 8, 2020 · 2 comments · Fixed by #1585
Closed

Filter field: Clear free text on lost focus #1572

OFouda opened this issue Sep 8, 2020 · 2 comments · Fixed by #1585
Labels
bug A broken behaviour that was working previously

Comments

@OFouda
Copy link

OFouda commented Sep 8, 2020

Bug Report<!---

Expected Behavior

Random text in filter field should be cleared on focus loss

Current Behavior

Text remains as it is.
In the filter field, users can type in some text that does not match any available option. This text remains in the field even after it looses focus which can wrongly give the impression that some filter is applied when it is not

Possible Solution

Remove any text in the field on focus loss and keep only the selected filter pills.

image

@lukasholzer
Copy link
Contributor

Reverted with #1650 as it caused side effects that the filter field is not working

@lukasholzer lukasholzer reopened this Sep 23, 2020
@thomaspink thomaspink added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 24, 2020
@lukasholzer lukasholzer added the Hacktoberfest 🎃 Issues that might be easy to start with: https://hacktoberfest.digitalocean.com/ label Oct 1, 2020
@lukasholzer
Copy link
Contributor

@OFouda I did short sync with @tomheller about this issue and in our opinion, it is working as expected. As it behaves like every other input field as well. Think about the use case that someone starts filtering then he copy-pastes an id or something into the field it would be cleared so every input is behaving the same. If you want to clear it to use command + A and then del.

So I will close this issue.

@lukasholzer lukasholzer removed Hacktoberfest 🎃 Issues that might be easy to start with: https://hacktoberfest.digitalocean.com/ filter-field Temporary label for filter field issues good first issue Good for newcomers help wanted Extra attention is needed labels Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A broken behaviour that was working previously
Projects
None yet
3 participants