This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
fix(filter-field): Fixes an issue where two filterfield flaps were open at the same time. #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaspink
previously approved these changes
Apr 8, 2020
|
Deploy preview for website ready! Built with commit f718c1c |
tomheller
force-pushed
the
fix/filter-field-not-closes-on-click-outside
branch
from
cf621d6
to
032d9de
Compare
|
I have added the |
ffriedl89
previously approved these changes
Apr 9, 2020
lukasholzer
previously approved these changes
Apr 9, 2020
tomheller
force-pushed
the
fix/filter-field-not-closes-on-click-outside
branch
from
032d9de
to
fdc3ff4
Compare
thomaspink
previously approved these changes
Apr 9, 2020
…en at the same time. To ensure that only one filterfield flap is open at the same time, we need to store the instance of the open flap in a global / module scope. If another filter field is focussed, it should close the panels of the currently opened one and then reassign itself into the open position. Fixes #840
tomheller
force-pushed
the
fix/filter-field-not-closes-on-click-outside
branch
from
fdc3ff4
to
447ade2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
lukasholzer
approved these changes
Apr 10, 2020
ffriedl89
approved these changes
Apr 10, 2020
github-actions
bot
added
target: minor
tomheller
added a commit
that referenced
this pull request
Nov 19, 2020
When clicking another combobox dropdown arrow (which stopped the event propagation), the autocomplete outside click was never triggered, preventing the blurred combobox from closing. A similar solution as in the filter-field #849 was applied to this. Fixes APM-269028
4 tasks
lukasholzer
pushed a commit
that referenced
this pull request
Nov 20, 2020
When clicking another combobox dropdown arrow (which stopped the event propagation), the autocomplete outside click was never triggered, preventing the blurred combobox from closing. A similar solution as in the filter-field #849 was applied to this. Fixes APM-269028
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2020
When clicking another combobox dropdown arrow (which stopped the event propagation), the autocomplete outside click was never triggered, preventing the blurred combobox from closing. A similar solution as in the filter-field #849 was applied to this. Fixes APM-269028
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2020
When clicking another combobox dropdown arrow (which stopped the event propagation), the autocomplete outside click was never triggered, preventing the blurred combobox from closing. A similar solution as in the filter-field #849 was applied to this. Fixes APM-269028
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
To ensure that only one filterfield flap is open at the same time, we need to store
the instance of the open flap in a global / module scope. If another filter field is focussed,
it should close the panels of the currently opened one and then reassign itself into the
open position.
Fixes #840
Type of PR
Bugfix
Checklist