Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Chart Range: Range scaling issue #99

Closed
ffriedl89 opened this issue Nov 13, 2019 · 6 comments
Closed

Chart Range: Range scaling issue #99

ffriedl89 opened this issue Nov 13, 2019 · 6 comments
Labels
bug A broken behaviour that was working previously no-issue-activity Issue is stale for more than 30 days P3 Important issue that needs to be resolved

Comments

@ffriedl89
Copy link
Collaborator

Range does not get upscaled correctly if the window is resized to a very small size and then resized very fast to a bigger size.

Check whether the viewport resizer uses the correct operators - we always need the last emission after the debounce time passed

@ffriedl89 ffriedl89 added bug A broken behaviour that was working previously P2 Issue that is important to resolve as soon as possible labels Nov 13, 2019
@dovidio
Copy link
Contributor

dovidio commented Dec 20, 2019

It seems to be related to the clamping done here:

const range = clampRange({ left, width }, this._maxWidth, 0);

When resizing fastly, left is clamped to maxWidth, and width is clamped to maxWidth - clampedLeft, which effectively clamp it to 0. Removing the clamping seems to solve the issue, however this might reintroduce the issue where it's possible to grow the selection outside the chart area

@github-actions
Copy link

github-actions bot commented Feb 7, 2020

This issue is stale, because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the no-issue-activity Issue is stale for more than 30 days label Feb 7, 2020
@ffriedl89 ffriedl89 removed the no-issue-activity Issue is stale for more than 30 days label Feb 7, 2020
@ffriedl89
Copy link
Collaborator Author

@lukasholzer Have you had a chance to take a look at this?

@ffriedl89
Copy link
Collaborator Author

I guess this is rather edge case-y, we can lower the priority in my opinion

@ffriedl89 ffriedl89 added P3 Important issue that needs to be resolved and removed P2 Issue that is important to resolve as soon as possible labels Feb 17, 2020
@lukasholzer
Copy link
Contributor

I think this is an operator issue that skips an emission due to debouncing. @dovidio thanks for your investigation but as you pointed out we need the clamping that nobody can resize the range larger than the highcharts container.

@github-actions
Copy link

This issue is stale, because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the no-issue-activity Issue is stale for more than 30 days label Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A broken behaviour that was working previously no-issue-activity Issue is stale for more than 30 days P3 Important issue that needs to be resolved
Projects
None yet
Development

No branches or pull requests

3 participants