Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not fail action when required property is empty #539

Open
luis-iaggbs opened this issue Dec 24, 2024 · 0 comments
Open

Does not fail action when required property is empty #539

luis-iaggbs opened this issue Dec 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@luis-iaggbs
Copy link

Hi team!

I hope you are doing well. I am writing to inform you about an issue we have encountered with one of our GitHub Actions

Description: We are using the dynatrace-oss/dynatrace-github-action@v9 to validate certain properties during our CI/CD process. One of these properties is meant to be required (i.e., it should not be empty). However, when this property is missing or left empty, the action only generates a warning and completes successfully. We need it to fail (exit with a non-zero status) in order to clearly surface this misconfiguration and block subsequent steps if the rule is violated.

      - name: 📈 Notify Deployment to Dynatrace
        id: dynatrace
        uses: dynatrace-oss/dynatrace-github-action@v9
        with:
          url: ${{ vars.DYNATRACE_URL }}
          token: ${{ secrets.DYNATRACE_RELEASE_KEY }}
          events: |
            - title: "${{ env.APP_NAME }}: Deployed - Version: ${{ inputs.version }}"
              type: "CUSTOM_DEPLOYMENT"
              entity-selector: tag("application-name:${{ env.APP_NAME }},tag("product-name:${{ github.event.repository.custom_properties.product-name }}"),tag("business-domain:${{ github.event.repository.custom_properties.business-domain }}")
              properties:
                source: 'GitHub Actions'
                ci-backend: 'github'
                dt.event.deployment.name: "${{ env.APP_NAME }} - Version: ${{ inputs.version }}"
                dt.event.deployment.release_product: "${{ env.APP_NAME }}"
                dt.event.deployment.project: ""
                dt.event.deployment.version: ""
                dt.event.deployment.release_stage: "" 
                dt.event.deployment.release_build_version: ""
                dt.event.deployment.ci_back_link: "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
                dt.event.deployment.remediation_action_link: "${{ github.server_url }}/${{ github.repository }}/releases"                        
                dt.event.is_rootcause_relevant: true
@luis-iaggbs luis-iaggbs added the bug Something isn't working label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant