Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource Region: slug field should not output region name #301

Closed
paulexyz opened this issue Nov 23, 2022 · 4 comments · Fixed by #302
Closed

Datasource Region: slug field should not output region name #301

paulexyz opened this issue Nov 23, 2022 · 4 comments · Fixed by #302
Labels
bug Something isn't working

Comments

@paulexyz
Copy link
Contributor

paulexyz commented Nov 23, 2022

If you query the datasource netbox_region the slug field should not give back the name.
I'm not familiar with developing TF modules but this might be the line the error is caused because the wrong field from the answer was referenced. I attached a PR down below fixing that line hope that's right...

Minimal steps to reproduce

data "netbox_region" "region" {
  filter {
    slug = "de-nue"
  }
}

output "data" {
  value = data.netbox_region.region
}

gives back the following

"data" = {
  "description" = ""
  "filter" = toset([
    {
      "id" = 0
      "name" = ""
      "slug" = "de-nue"
    },
  ])
  "id" = 21
  "name" = "Nürnberg"
  "parent_region_id" = 6
  "slug" = "Nürnberg"
}
@paulexyz
Copy link
Contributor Author

Thanks for the fast response times! Do you have any rough estimate when i can expect this fix to be in a release?

@fbreckle
Copy link
Collaborator

fbreckle commented Nov 24, 2022

Usually, I wait until enough "release-worthy" stuff accumulates before releasing. Yes, this is extremely random and subjective :P
If you need the change quickly, I can just make a release containing only the patch, just ping me here.

@paulexyz
Copy link
Contributor Author

I don't wanna spam releases, but if you could create a release for this fix that wold be awesome! That would spare me the hassle to build that module myself until the next release...

And yes even if that may seem random, this project seems very good maintained so I don't have anything to complain about 😉

@fbreckle
Copy link
Collaborator

https://github.com/e-breuninger/terraform-provider-netbox/releases/tag/v3.0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants