Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name conventions #87

Closed
torabi12 opened this issue Feb 25, 2023 · 1 comment · Fixed by e-m-b-a/emba#495
Closed

Name conventions #87

torabi12 opened this issue Feb 25, 2023 · 1 comment · Fixed by e-m-b-a/emba#495
Labels
bug Something isn't working EMBA

Comments

@torabi12
Copy link

Describe the bug
I created a "D-Link" vendor in EMBArk but the test did not start, because the name contains hyphen, which is blocked by EMBA.
I tried to start the same test without selecting the existing vendor but the test also did not start. I created again a new scan with DLink vendor and it worked fine:

kép

To Reproduce
Steps to reproduce the behavior:

  1. EMBArk installation default-mode
  2. Start EMBArk: sudo ./run-server.sh -a
  3. Use the firmware available here: anything
  4. Create a vendor or device with a non supported character and assign it to the FW file and try to start the scan.
  5. There is no error, the test stops after a few seconds.

Expected behavior
EMBArk should warn the user and only the supported characters would be accepted on the page.

Screenshots
See above.

Desktop (please complete the following information):

  • OS: Ubuntu Server 22.04.1
@m-1-k-3
Copy link
Member

m-1-k-3 commented Feb 25, 2023

we need to adjust these filters. As quick fix I have included further allowed characters (-_) in EMBA.

@m-1-k-3 m-1-k-3 added bug Something isn't working EMBA labels Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EMBA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants