Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing test coverage in staff/views.py #1630

Closed
11 tasks
niklasmohrin opened this issue Sep 27, 2021 · 0 comments
Closed
11 tasks

Missing test coverage in staff/views.py #1630

niklasmohrin opened this issue Sep 27, 2021 · 0 comments
Labels
[C] Tests and CI New or better testing and CI [P] Medium Medium priority

Comments

@niklasmohrin
Copy link
Member

The coverage in staff/views.py is rather low, here are some spots that seem important-ish

  • semester_grade_reminder
  • semester_archive_{participants, results}, semester_delete_grade_documents, {evaluation, course}_delete: these just forward to the methods on the database objects / instances; I suppose these are tested then, right?
  • course_create with semester.participations_are_archived
  • evaluation_edit with evaluation.is_single_resultand helper_single_result_edit itself
  • we never evaluation.reopen_evaluation() or evaluation.manager_approve() within evaluation_edit
  • get_evaluation_and_contributor_textanswer_sections with filter_textanswers or with general contributions or the cases where no answers exist (not sure if these are even possible)
  • questionnaire_index with filter_questionnaires
  • make_questionnaire_edit_forms with editable
  • questionnaire_edit where the form and formset are valid
  • user_index with filter_users
  • export_contributor_results_view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Tests and CI New or better testing and CI [P] Medium Medium priority
Development

No branches or pull requests

2 participants