Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use forms for staff/evaluations/textanswers_* instead of Ajax #1698

Closed
niklasmohrin opened this issue Jan 17, 2022 · 0 comments · Fixed by #1705
Closed

Use forms for staff/evaluations/textanswers_* instead of Ajax #1698

niklasmohrin opened this issue Jan 17, 2022 · 0 comments · Fixed by #1705
Labels
[C] Backend Focuses on backend implementation [P] Nice to have Lowest priority. Some people might use this feature but it won't have a big impact. [S] Easy This issue is self-contained and does not touch too many parts. Good choice for beginners. [T] Refactoring Existing parts should become faster, more readable, or in any other way better.

Comments

@niklasmohrin
Copy link
Member

The textanswer review sites have forms, that are actually sent with ajax instead of html form sends, because we don't want to reload the site. We could remove the javascript code and instead have the server (view: evaluation_textanswers_update_publish) return HTTP 204. PR #1689 introduces another response with a url to navigate to, this could then be refactored to be a normal redirect instead.
@niklasmohrin niklasmohrin added [C] Backend Focuses on backend implementation [P] Nice to have Lowest priority. Some people might use this feature but it won't have a big impact. [T] Refactoring Existing parts should become faster, more readable, or in any other way better. [S] Easy This issue is self-contained and does not touch too many parts. Good choice for beginners. labels Jan 17, 2022
@niklasmohrin niklasmohrin mentioned this issue Jan 24, 2022
Closed
@niklasmohrin niklasmohrin mentioned this issue Feb 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[C] Backend Focuses on backend implementation [P] Nice to have Lowest priority. Some people might use this feature but it won't have a big impact. [S] Easy This issue is self-contained and does not touch too many parts. Good choice for beginners. [T] Refactoring Existing parts should become faster, more readable, or in any other way better.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use standard forms instead of javascript submit for textanswer review niklasmohrin/EvaP
1 participant
@niklasmohrin