Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modals specify ids for their buttons that are never used #1722

Closed
richardebeling opened this issue Mar 15, 2022 · 0 comments · Fixed by #1755
Closed

Modals specify ids for their buttons that are never used #1722

richardebeling opened this issue Mar 15, 2022 · 0 comments · Fixed by #1755
Labels
[C] Backend Focuses on backend implementation [P] Nice to have Lowest priority. Some people might use this feature but it won't have a big impact. [S] Very small This issue should require only very small changes.

Comments

@richardebeling
Copy link
Member

On some pages, e.g. here:

EvaP/evap/contributor/templates/contributor_evaluation_form.html

Line 68 in cb518fc

<button type="button" class="btn btn-sm btn-light" onclick="changeEvaluationRequestModalShow();" id="changeEvaluationRequestModalButton">

the buttons that open up modals have ids set that seem to be unused. A grep for ModalButton should find the occurrces.

Originally posted by @he3lixxx in #1639 (comment)
@richardebeling richardebeling added [C] Backend Focuses on backend implementation [P] Nice to have Lowest priority. Some people might use this feature but it won't have a big impact. [S] Very small This issue should require only very small changes. labels Mar 15, 2022
@Kakadus Kakadus mentioned this issue May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[C] Backend Focuses on backend implementation [P] Nice to have Lowest priority. Some people might use this feature but it won't have a big impact. [S] Very small This issue should require only very small changes.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove modal button ids Kakadus/EvaP
1 participant
@richardebeling