Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open evaluations in new tabs #2292

Closed
janno42 opened this issue Sep 30, 2024 · 3 comments · Fixed by #2349
Closed

Open evaluations in new tabs #2292

janno42 opened this issue Sep 30, 2024 · 3 comments · Fixed by #2349
Assignees
@niklasmohrin
Labels
[C] Frontend Focuses on frontend implementation [P] Major Major priority [S] Small This issue should require only small changes.
Milestone
Winter 2024

Comments

@janno42
Copy link
Member

janno42 commented Sep 30, 2024

Control-clicking on evaluation rows on student index and contributor index should open the pages in new tabs (see results page for an example).
Currently, clicking reloads the page.
@janno42 janno42 added [C] Frontend Focuses on frontend implementation [P] Major Major priority [S] Small This issue should require only small changes. labels Sep 30, 2024
@janno42 janno42 added this to the Winter 2024 milestone Oct 7, 2024
@niklasmohrin
Copy link
Member

I think this is a regression introduced in #2117

@niklasmohrin niklasmohrin self-assigned this Dec 2, 2024
@niklasmohrin niklasmohrin mentioned this issue Dec 2, 2024
Merged
@janno42
Copy link
Member Author

janno42 commented Dec 2, 2024

I think this is a regression introduced in #2117

You mean the frontend change that I didn't test? 😅

@niklasmohrin
Copy link
Member

I stand by my change and blame the reviewers 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niklasmohrin niklasmohrin

Labels
[C] Frontend Focuses on frontend implementation [P] Major Major priority [S] Small This issue should require only small changes.
Milestone
Winter 2024
2 participants
@janno42 @niklasmohrin