Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion / enhancement - to define default size for boostrap buttons #2160

Closed
Jimmi08 opened this issue Dec 17, 2016 · 3 comments
Closed
Labels
Help Wanted status: awaiting feedback This issue may be fixed and is awaiting the original poster to confirm the fix.
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Dec 17, 2016

I noticed that buttons in menus has different size,
chat menu - btn btn-default button
private message - btn btn-mini btn-xs btn-default
news by months - btn btn-default btn-sm
user.php - btn btn-default

Styling this is nightmare. There should be some rules, f.e. in menus btn btn-xs btn-default , for pages
btn btn-sm btn-default (or btn btn-default).

The same for input element just with added class button. .

These element (buttons with a tag or input tag) should have one common class like tbox before to be able styling theme all in one. And of course unique ID selector too.

The need override this with shortcodes or templates reduce power of using bootstrap as default framework for templating.

@Moc Moc added the status: awaiting feedback This issue may be fixed and is awaiting the original poster to confirm the fix. label Dec 17, 2016
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Dec 18, 2016

blogcalendar_menu button:
blogcalendar-archive-link btn btn-small btn-s btn-primary

  • first button should be always default or primary - if you want all button the same, you need btn_default and btn_primary the same colour.

@Moc Moc added the Help Wanted label Feb 2, 2017
@Moc Moc added this to the Future milestone Feb 28, 2018
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented May 2, 2020

signup template uses btn-success
<input class='button btn btn-success' type='submit' name='register' value=\"".LAN_SIGNUP_79."\" />

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented May 2, 2020

@CaMer0n
Could you consider remove large class from core login template?
{LOGIN_TABLE_SUBMIT} instead {LOGIN_TABLE_SUBMIT=large} ?

@CaMer0n CaMer0n closed this as completed in ba36dd2 May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted status: awaiting feedback This issue may be fixed and is awaiting the original poster to confirm the fix.
Projects
None yet
Development

No branches or pull requests

2 participants