Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using {SITELOGO: h=xx} - errors in console #2981

Closed
Jimmi08 opened this issue Jan 17, 2018 · 8 comments
Closed

using {SITELOGO: h=xx} - errors in console #2981

Jimmi08 opened this issue Jan 17, 2018 · 8 comments
Assignees
Labels
type: bug A problem that should not be happening
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jan 17, 2018

I thought that this was already fixed but it's back again

image

using shortcode {SITELOGO: h=xx} only with height param is standard way used in default bootstrap3 theme too. Check boostrap branding shortcode.

@Moc Moc added the type: bug A problem that should not be happening label Jan 17, 2018
@LaocheXe
Copy link
Member

In Defiantzstrap3 (Modified Bootstrap3 theme) I have in theme_shortcodes.php

return e107::getParser()->parseTemplate('{SITELOGO: h='.$prefh.'}',true);

I have not hit that issue yet

@Moc Moc added this to the e107 2.1.8 milestone Mar 5, 2018
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jun 22, 2018

This is still issue. Maybe theme.php is parsed differently.

Using {SITELOGO} - no errors in console
Using {SITELOGO: h=100} - the same errors

image

@CaMer0n CaMer0n modified the milestones: e107 2.1.8, e107 2.1.9 Jul 18, 2018
@CaMer0n CaMer0n modified the milestones: e107 2.1.9, e107 2.2.0 Aug 22, 2018
@Moc Moc added the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Feb 1, 2019
@Moc
Copy link
Member

Moc commented Feb 1, 2019

@LaocheXe Is this still an issue?

@LaocheXe
Copy link
Member

LaocheXe commented Feb 2, 2019

@Moc I don't know, never had the issue, should check with @Jimmi08

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Feb 9, 2019

Still problem. Used directly, not parsing template:

{SITELOGO: h=100}
in Gameplus theme from Fizi in $LAYOUT['header']

image

Sorry, closed by mistake.

@Jimmi08 Jimmi08 closed this as completed Feb 9, 2019
@Jimmi08 Jimmi08 reopened this Feb 9, 2019
@Moc Moc removed the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Feb 11, 2019
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Feb 26, 2019

Confirmed with the latest version:
But only Chrome has a problem. Firefox no errors.

image

@CaMer0n CaMer0n modified the milestones: e107 2.2.0, e107 2.2.1 May 18, 2019
@CaMer0n
Copy link
Member

CaMer0n commented May 27, 2019

@CaMer0n CaMer0n modified the milestones: e107 2.2.1, e107 2.2.2 May 27, 2019
@CaMer0n CaMer0n self-assigned this Apr 10, 2020
@CaMer0n
Copy link
Member

CaMer0n commented Apr 10, 2020

@Jimmi08 @LaocheXe This commit should fix it. Please re-open the issue if you notice any unexpected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

4 participants