Language admin ui bug

[rica-carv]

The second option of the side menu doesn't allow the display of the admin ui dropdown menus....
1st menu option, correct:

2nd menu option, incorrect:

Furthermore, the second option currently doesn't displays nothing.

Today's github files...

[tgtje]

I just mention it: please check : The Portugese lang pack is 3 years old> LANG_LAN_04 (admin/lan_language php)
;listing of file
define("LANG_LAN_03", "Tabelas");
define("LANG_LAN_05", "Não instalado");

English : define("LANG_LAN_04", "Deprecated LANs");

[rica-carv]

@tgtje Not quite, it was updated in 2017, by me.
And now, when i was trying to update it, the admin ui has these errors, which were not there previously....

Furthermore, this happens either in English o Portuguese, so it must be a non language related bug...

[tgtje]

Yes i thought you worked on it, i use the pack available from content management ..., most of the files are 3 y. :;)
Anyway : fresh github new install (local 7.1.1)

No issues not in English, not in Dutch and also not to be seen using P. (lang check reports 736 issues with v2 lang pack P. )....... ?????

[rica-carv]

@tgtje Beware, you're testing it in php 7.1.1, i'm with 5.4.....
I already expressed my fears because all the changes made to suit php 7.x
It's the direction to go, but if almost everything is stop working in 5.4, why not make minumum requirements php 7.x???

[tgtje]

@rica-carv did install a local wamp (php 5.4.12) After enabling curl and exif all worked fine.
However your issue appears indeed in this version.
after fiddling around i (mind my liitlte coding experience) it comes to line 899 of the E107_admin/lancheck php > if(!empty(e_VERSION)) (it is the empty (think defined would be better according coders??) and the last ). commenting (disabling) this line has result (for me and page appears)

[rica-carv]

After clean install of today's github files, CURL enabled in php 5.4, problem still persists....

[Moc]

PHP 5.4 has not been supported by PHP since end of of 2015. It's time to move to PHP 5.6 at the very least.

We (e107) need to make sure that PHP 7.1+ is supported properly.

[Moc]

Having said that, if this issue still occurs in PHP 5.6, then it needs to be fixed.

[tgtje]

Just tested on a existing 5.6.32 (local) site d.d. feb 2018 no issues.

However i synced it now to github (2.1.9) and above mentioned issue is present > debug shows no error.
applying the same 'fix' does NOT help. So error is likely somewhere else....

[rica-carv]

Tested in PHP v5.6, and working...