Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password reset is conflicting with "intelligent webmail" like outlook.com #3443

Closed
simplythomasjay opened this issue Sep 21, 2018 · 5 comments
Labels
status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. type: bug A problem that should not be happening type: enhancement An improvement or new feature request
Milestone

Comments

@simplythomasjay
Copy link

The last couple of days I tested password reset.
And today I know one of the problems that is killing password reset.
The web-interface of Outlook.com is preloading a preview of the website and embedding it into the e-Mail-text.
And this preloading thing is killing the database-row in the tmp-database.

solution:
The link opens a website with a button and this button triggers the new pwd feature.

Second issue:
$rcode = crypt(($_SERVER['HTTP_USER_AGENT'] . serialize($pref). $clean_email . $datekey), e_TOKEN);

In $rcode there are signs like - / _ but later on this signs will be preg_replaced to protect from SQL injection.

A solution to this could be:

$rcode = e107::getUserSession()->generateRandomString( '############' );
Now you generate a clean Random string with only upper case and lower case letters of the alphabet.

@Moc Moc added type: bug A problem that should not be happening status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. type: enhancement An improvement or new feature request labels Sep 21, 2018
@Moc Moc added this to the e107 2.2.0 milestone Sep 21, 2018
@Moc
Copy link
Member

Moc commented Sep 24, 2018

As for the first issue, I am not sure if this is something that should be fixed by e107. Outlook users should know that the preview functionality in that application is meant as preview, not as an actual working "browser".

As for the second issue, what do you think @CaMer0n?

@simplythomasjay
Copy link
Author

The first issue has to be fixed - it is important.

Users with normal Webmail-email-adress don't see a problem with password reset.

But users with a outlook.com adress has per default a feature activated that is "screengrabbing" the content of the linked website.
For example you embed a youtube-link into an e-mail and you send it to an outlook.com adress.
Then outlook.com show you the text of the e-mail plus a small site-preview of the website (inside of the main text of the email-message).

Same happen with the activation-link.

The "intelligent" outlook.com grabs the content of the link and while doing so it deletes the database-row in the tmp-table.

Next step the user clicks on the link but now it sees a window with "error - this is not a working activation link".

I have fixed this now with
https://somesite.com/fpw.php?previewAysqWmnEr as email-link.

And this link shows an activation site with a link on it
https://somesite.com/fpw.php?enabledAysqWmnEr
And the user has to actively click on this link and the next site shows the new password.

I hope this is clearer now.
This is some sort of a gaslighting-bug.
Because first up everywhere else is a bug - you are getting comleptely nuts with this bug.

@CaMer0n
Copy link
Member

CaMer0n commented Sep 25, 2018

@simplythomasjay Thank you for bringing it to our attention. I believe a time-limit on the link might work better in this case. (rather than deleting the row immediately after use) .

@Moc Moc modified the milestones: e107 2.2.0, Future Jan 31, 2019
@mostym
Copy link

mostym commented Feb 28, 2019

@Moc @CaMer0n @simplythomasjay I am experiencing this same issue for users that are trying reset from hotmail as well. Is there a temp fix for this?

@CaMer0n CaMer0n modified the milestones: Future, e107 2.2.0 Feb 28, 2019
@CaMer0n
Copy link
Member

CaMer0n commented Feb 28, 2019

Will try to get this fixed soon.

@Moc Moc added type: enhancement An improvement or new feature request and removed type: enhancement An improvement or new feature request labels Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. type: bug A problem that should not be happening type: enhancement An improvement or new feature request
Projects
None yet
Development

No branches or pull requests

4 participants