Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic update from plugin from e107.org may overwrite 'not registered' plugin #3711

Closed
Alex-e107nl opened this issue Mar 5, 2019 · 8 comments
Labels
type: enhancement An improvement or new feature request
Milestone

Comments

@Alex-e107nl
Copy link
Contributor

Sorry if it's not completely clear, i use the survey plugin to make forms, it's an oldy but functions, someone has placed a plugin in the system with the same name and everywhere i have installed the old survey the new one (it's really not the same) is overwriting the old one.

Can someone do something about that?

Thx
Alex

@Jimmi08
Copy link
Contributor

Jimmi08 commented Mar 5, 2019

Yes, it was discussed on Gitter. You can't click on update.

@Moc Moc added the type: enhancement An improvement or new feature request label Mar 6, 2019
@Moc
Copy link
Member

Moc commented Mar 6, 2019

This is caused by the fact that the plugin author chose not to upload their plugin to e107.org. In this case, it is not 'registered'. In the mean time, another plugin author uploaded a plugin with the same name (and with a newer version). This new plugin then overwrites the older 'not registered' plugin.

I do agree that there should be some form of warning or perhaps enhanced checks in order to avoid this situation from happening. However, I do recommend that all plugin authors upload their plugin to e107.org to make use of all the functionalities e107 offers.

Sidenote: a backup of the old plugin files is always stored when doing automatic updates (system/backup folder)

@Moc Moc changed the title Survey plugin gets an update and then its a whole new other plugin.... Automatic update from plugin from e107.org may overwrite 'not registered' plugin Mar 6, 2019
@Moc Moc added this to the e107 2.2.0 milestone Mar 19, 2019
@Jimmi08
Copy link
Contributor

Jimmi08 commented Mar 20, 2019

That new survey plugin should be removed from e107.org. In fact, it's the only copy of the poll plugin and renamed tables. There should be a list of e107 plugins with reserved names.

I started to add "jm" to my plugins to avoid this problem, but the same thing could happen to the canonical plugin. I could upload mine, then CaMeRon's one could be overwritten. But I knew that there is the unregistered plugin with this name, so I changed its name.

And from curiosity - how is checked compatibility with e107 core? One version is compatible with f.e. 2.1.9, but then there is new version only for 2.2.0. Will user get the notification about to update to new version although is not compatible with their core?

@LaocheXe
Copy link
Member

Maybe we could add a unique id to the plugin xml, that would be use to cross check plugins, themes, etc... Just throwing out ideas here

@Jimmi08
Copy link
Contributor

Jimmi08 commented Mar 20, 2019

Easier is check plugin name and plugin author. Both values.

@CaMer0n
Copy link
Member

CaMer0n commented Apr 11, 2019

@Alex-e107nl If you reinstall the septor version of survey, e107 should no longer suggest an updated version from e107.org. (following the changes I just made)

@Alex-e107nl
Copy link
Contributor Author

Very nice Cameron THX! Will test it of course!!

@CaMer0n
Copy link
Member

CaMer0n commented May 1, 2019

@Alex-e107nl Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An improvement or new feature request
Projects
None yet
Development

No branches or pull requests

5 participants