Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chatbox notify title - html code is there #3726

Closed
Jimmi08 opened this issue Mar 12, 2019 · 5 comments
Closed

chatbox notify title - html code is there #3726

Jimmi08 opened this issue Mar 12, 2019 · 5 comments
Assignees
Labels
plugin: chatbox type: bug A problem that should not be happening
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Mar 12, 2019

Subject of chatbox notify email

image

@Moc Moc added type: bug A problem that should not be happening plugin: chatbox status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. and removed type: bug A problem that should not be happening labels Mar 12, 2019
@Moc
Copy link
Member

Moc commented Mar 12, 2019

Hmm, I cannot reproduce this. I do not see any reason in the code that would cause this.
I assume you are using the latest files?

Which theme are you using?

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Mar 12, 2019

@Moc RideBlue2

@Moc
Copy link
Member

Moc commented Mar 12, 2019

I reproduced the issue on RideBlue2, looking into it.

@Moc Moc added type: bug A problem that should not be happening and removed status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. labels Mar 12, 2019
@Moc
Copy link
Member

Moc commented Oct 24, 2019

Ok, took a while but I found the issue. Not sure about the fix though:

@CaMer0n
in e107_handlers/mail.php on line 856, this is done:

$this->Subject = $tp->parseTemplate($tmpl['subject'], true, varset($eml['shortcodes'],null));

It merges with this in the RideBlue2 theme.php, used for the $COMMENTSTYLE in theme.php.

$sc_style["SUBJECT"]["pre"] = '<td class="forumheader">';
$sc_style["SUBJECT"]["post"] = '</td></tr>';

I see a note here in e107_handlers/mail.php on line 834 when loading the email template:

if($tmpl = e107::getCoreTemplate('email', $eml['template'], 'front', true))  //FIXME - Core template is failing with template 'notify'. Works with theme template. Issue with core template registry?

Can you take a look please?

@Moc Moc added this to the e107 2.2.2 milestone Oct 24, 2019
@CaMer0n CaMer0n closed this as completed in 1c8e755 Jun 2, 2020
@CaMer0n
Copy link
Member

CaMer0n commented Jun 2, 2020

@Moc Thanks for the tips.

I believe the commit should fix it, but if not, please re-open. Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: chatbox type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

3 participants