Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parms doesn't work with new Admin UI with datestamp field #3759

Closed
Jimmi08 opened this issue Mar 25, 2019 · 4 comments
Closed

parms doesn't work with new Admin UI with datestamp field #3759

Jimmi08 opened this issue Mar 25, 2019 · 4 comments
Labels
core: news status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing.

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Mar 25, 2019

Now you need to put "mask" to ReadParms, "parms" is ignored in renderValue(). You can try this on news in admin UI.

'news_datestamp'		=> array('title' => LAN_NEWS_32, 	'type' => 'datestamp', 'data'=>'int', 'tab'=>2,  
		 'writeParms'=>'type=datetime',   'width' => 'auto', 	'thclass' => '', 				'class' => null, 		'nosort' => false,
		  'parms' => 'mask=%A %d %B %Y', 'filter'=>true),
@Moc Moc added the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Mar 29, 2019
@CaMer0n
Copy link
Member

CaMer0n commented Apr 3, 2019

Looks like old code to me. There is only readParms and writeParms.

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jan 7, 2020

@Moc should be labeled core:news. Problem is news code, not in AdminUI.

@CaMer0n CaMer0n added type: bug A problem that should not be happening and removed type: bug A problem that should not be happening labels Feb 14, 2020
@CaMer0n
Copy link
Member

CaMer0n commented Feb 14, 2020

@Jimmi08 Is there a functional issue? If not, I believe this old code could simply be removed.

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Feb 14, 2020

I agree, I was just looking through files for an example of parms with mask and I noticed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core: news status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing.
Projects
None yet
Development

No branches or pull requests

4 participants