Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voux welcome page hardcoded admin page #3775

Closed
nlstart opened this issue Apr 3, 2019 · 5 comments
Closed

Voux welcome page hardcoded admin page #3775

nlstart opened this issue Apr 3, 2019 · 5 comments
Labels
type: bug A problem that should not be happening
Milestone
e107 2.2.1

Comments

@nlstart
Copy link
Contributor

nlstart commented Apr 3, 2019

e107/e107_themes/voux/install/install.xml
contains hardcoded text to the admin page (around line 1101):
<a class=&quot;btn btn-primary btn-large &quot; href=&quot;e107_admin/admin.php&quot;>Go to Admin area</a>
To make it follow the settings from e107_config.php this might be better:
<a class=&quot;btn btn-primary btn-large &quot; href=&quot;{e_ADMIN}admin.php&quot;>Go to Admin area</a>
@CaMer0n
Copy link
Member

CaMer0n commented Apr 3, 2019

Happy to see you @nlstart! 👍

@CaMer0n CaMer0n added the type: bug A problem that should not be happening label Apr 3, 2019
@nlstart
Copy link
Contributor Author

nlstart commented Apr 3, 2019

Thank you for the warm welcome @CaMer0n, it has been way too long! :-)

@Moc
Copy link
Member

Moc commented Apr 3, 2019

Good to see you!

@nlstart
Copy link
Contributor Author

nlstart commented Apr 3, 2019 •
edited
Loading

Identical issues in:
e107_themes\bootstrap3\install\install.xml (line 12)
e107_themes\landingzero\install\install.xml (line 50)

@CaMer0n CaMer0n added this to the e107 2.2.0 milestone Apr 6, 2019
@CaMer0n CaMer0n closed this as completed in 63186e7 Apr 6, 2019
@CaMer0n CaMer0n modified the milestones: e107 2.2.0, e107 2.2.1 May 20, 2019
@CaMer0n
Copy link
Member

CaMer0n commented May 20, 2019

Unfortunately, it seems this broke the link in v2.2.0. Reassigned for 2.2.1

@CaMer0n CaMer0n reopened this May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A problem that should not be happening
Projects
None yet
Milestone
e107 2.2.1
Development

No branches or pull requests
3 participants
@Moc @nlstart @CaMer0n