Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Message title setting doesn't seem to do anything #3925

Closed
fsLeg opened this issue Aug 18, 2019 · 2 comments
Closed

Private Message title setting doesn't seem to do anything #3925

fsLeg opened this issue Aug 18, 2019 · 2 comments
Assignees
Labels
plugin: pm type: bug A problem that should not be happening
Milestone

Comments

@fsLeg
Copy link

fsLeg commented Aug 18, 2019

Today, a friend of mine who came up with a theme I'm working on asked if I could change pm_menu's title. Apparently, I could, as there's a field just for that in admin panel.
image

Or so I thought, because changing the field does absolutely nothing, menu's title (the one tablestyle() sees as $caption) is still being pulled from LAN_PM. I clicked seemingly everywhere within the plugin, both menu and a dedicated page, but the title I set was nowhere to be seen.

Am I missing something or is it a bogus setting?

@Jimmi08
Copy link
Contributor

Jimmi08 commented Aug 19, 2019

Yes, you are right. And there is not used PMLAN_PM value used too.
Quick fix:

replace

$ns->tablerender(LAN_PM, $txt, 'pm');

with

	$caption = varset($pmManager->prefs()['title'],LAN_PM);
	$ns->tablerender($caption, $txt, 'pm');

@Moc Moc added the type: bug A problem that should not be happening label Aug 26, 2019
@Moc Moc added this to the e107 2.2.2 milestone Aug 26, 2019
@Moc Moc self-assigned this Aug 26, 2019
@Moc Moc added the plugin: pm label Aug 26, 2019
@Moc Moc closed this as completed in 1e930ed Aug 27, 2019
@Moc
Copy link
Member

Moc commented Aug 27, 2019

Fixed. Also cleaned up the code a bit. Thanks @fsLeg and @Jimmi08!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: pm type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

3 participants