Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct path for images folder for forum plugin #3948

Closed
Jimmi08 opened this issue Sep 4, 2019 · 0 comments
Closed

correct path for images folder for forum plugin #3948

Jimmi08 opened this issue Sep 4, 2019 · 0 comments
Assignees
@Moc
Labels
plugin: forum status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. type: bug A problem that should not be happening type: enhancement An improvement or new feature request
Milestone
e107 2.3.0

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Sep 4, 2019 •
edited
Loading

Paths inside function img_path($filename) in forum needs to update.

The path for the plugin is correct: e_PLUGIN.'forum/images/icons/
but for theme is THEME.'forum/'.$filename - missing images folder
now there are templates too, so images should be in separate subfolder too.

Nothing important, just reminder.
@Moc Moc added type: bug A problem that should not be happening plugin: forum labels Sep 4, 2019
@Moc Moc changed the title FR - correct path for images folder for forum plugin correct path for images folder for forum plugin Sep 18, 2019
@Moc Moc self-assigned this Sep 30, 2019
@Moc Moc added status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. type: enhancement An improvement or new feature request labels Sep 30, 2019
@Moc Moc added this to the e107 2.2.2 milestone Oct 2, 2019
@Moc Moc closed this as completed in 18243e7 Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Moc Moc

Labels
plugin: forum status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. type: bug A problem that should not be happening type: enhancement An improvement or new feature request
Projects
None yet
Milestone
e107 2.3.0
Development

No branches or pull requests
2 participants
@Moc @Jimmi08