Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add $host variable support to Downloads » Protection » NGINX secure_link_md5 #4010

Closed
Deltik opened this issue Nov 5, 2019 · 0 comments · Fixed by #4011
Closed

Add $host variable support to Downloads » Protection » NGINX secure_link_md5 #4010

Deltik opened this issue Nov 5, 2019 · 0 comments · Fixed by #4011
Labels
plugin: download type: enhancement An improvement or new feature request

Comments

@Deltik
Copy link
Member

Deltik commented Nov 5, 2019 •
edited
Loading

This request came from @mostym.
This is an enhancement to #3075.

Problem

If there are two download mirrors, slow.example.com and fast.example.com, hotlink protection using an NGINX secure_link_md5 expression in the Downloads plugin cannot distinguish between these hostnames.

This means that a user limited to slow.example.com can change the download host to fast.example.com and download from the better mirror.

Solution

To solve this, NginxSecureLinkMd5Decorator needs to support the NGINX $host variable. Having this variable in the expression will lock down the secure link to the specific download host.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin: download type: enhancement An improvement or new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support NGINX $host in Downloads hotlink protection
2 participants
@Moc @Deltik