Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hardcoded value for parameter order in render_newsgrid() #4092

Closed
Jimmi08 opened this issue Feb 6, 2020 · 1 comment
Closed

remove hardcoded value for parameter order in render_newsgrid() #4092

Jimmi08 opened this issue Feb 6, 2020 · 1 comment
Labels
core: news type: enhancement An improvement or new feature request
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Feb 6, 2020

Motivation

Flexibility with using render_newsgrid() method
Example: need to display some news in alphabetical order

Proposed Solution

No changes in the grid menu itself, it's correct.

Problem is that from documentation there is parameter order
@param integer $parm['order'] n.news_datestamp DESC

but it is hardcoded later:
$parms['order'] = 'n.news_datestamp DESC';

It could be solved similar way as normal news:
$db_order = vartrue($params['db_order'], 'n.news_datestamp DESC');

Thanks

@Jimmi08 Jimmi08 added the type: enhancement An improvement or new feature request label Feb 6, 2020
@CaMer0n CaMer0n added this to the e107 2.3.0 milestone Feb 10, 2020
@CaMer0n
Copy link
Member

CaMer0n commented Feb 10, 2020

@Jimmi08 This commit should fix it, but please let me know if it didn't for some reason.

@Moc Moc added the core: news label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core: news type: enhancement An improvement or new feature request
Projects
None yet
Development

No branches or pull requests

3 participants