Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow 2.3 compatible themes to use on 2.1 core and older #4200

Closed
Jimmi08 opened this issue Jun 20, 2020 · 2 comments
Closed

Don't allow 2.3 compatible themes to use on 2.1 core and older #4200

Jimmi08 opened this issue Jun 20, 2020 · 2 comments
Assignees
Labels
type: bug A problem that should not be happening
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jun 20, 2020

Bug Description

There is no information about compatibility on the e107.org themes browser.

Label in Theme manager says only Recommended, that it is not true. Core e107 2.3.0 beta is mandatory not recommended if the theme is marked as compatible with 2.3.0.
(Github version at least from April 2020 is needed)

Otherwise, the user breaks their site.

@Jimmi08 Jimmi08 added the type: bug A problem that should not be happening label Jun 20, 2020
@tgtje
Copy link
Contributor

tgtje commented Jun 23, 2020

Good idea, but it should then also be similar behaviour in core Find themes to be complete.

Just adding as reference (needs to be tested)
During 'activation' of theme in site :
Could it rely on 'dependencies' like in plugins? Although this would be at a later point in time.
To overcome any issues..

@CaMer0n CaMer0n added this to the e107 2.3.0 milestone Jul 1, 2020
@CaMer0n CaMer0n self-assigned this Jul 1, 2020
@CaMer0n CaMer0n closed this as completed in 582bd3f Jul 1, 2020
@CaMer0n
Copy link
Member

CaMer0n commented Jul 1, 2020

@Jimmi08 Please give it a test drive. Thanks. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

3 participants