Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Open Premium Theme URL in a new window #4208

Closed
Jimmi08 opened this issue Jul 6, 2020 · 0 comments
Closed

Feature Request: Open Premium Theme URL in a new window #4208

Jimmi08 opened this issue Jul 6, 2020 · 0 comments
Labels
type: enhancement An improvement or new feature request type: question An ask about behavior that is not found documented anywhere
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jul 6, 2020

Question

Why is URL to premium theme displayed in iframe and user is not redirected to the shop?

You said that this URL has to point to a page with a cart button or any commercial solution to approve the premium theme some time ago.

But because you are displaying content of this URL in the iframe (inside theme manager), user is able to use cart and checkout inside this iframe. In the modal window.

I noticed a problem when the new version of the solution I use, enforce same-origin iframe use only (except embed carts)

With a premium theme, you should redirect to the given URL.

Probably I could use news/page with embed shop, but it doesn't solve this - you still will display all processes inside iframe...

And I noticed you are hashing URL to shop, so nobody is able to use the direct link.

And there is different behavior for this on e107.org.

Thanks

@Jimmi08 Jimmi08 added the type: question An ask about behavior that is not found documented anywhere label Jul 6, 2020
@CaMer0n CaMer0n added this to the e107 2.3.0 milestone Jul 7, 2020
@CaMer0n CaMer0n changed the title Premium theme and Find theme in Theme manager Feature Request: Open Premium Theme URL in a new window Jul 7, 2020
@CaMer0n CaMer0n added the type: enhancement An improvement or new feature request label Jul 7, 2020
@CaMer0n CaMer0n closed this as completed in d1c235a Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An improvement or new feature request type: question An ask about behavior that is not found documented anywhere
Projects
None yet
Development

No branches or pull requests

2 participants