Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forum - issue with forum topic pagination #4722

Closed
Jimmi08 opened this issue Mar 28, 2022 · 1 comment
Closed

forum - issue with forum topic pagination #4722

Jimmi08 opened this issue Mar 28, 2022 · 1 comment
Labels
plugin: forum type: enhancement An improvement or new feature request

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Mar 28, 2022

Motivation

pagination on forum topic is done with ?p=1 ?p=2 etc

Problem is that you can use any parameter and the page is displayed (no 404 error, no error message, anything)

It shouldn't work this way

Proposed Solution

No idea for now, just marked.

Note:
if you use by mistake for example: ?p=-3
you got fatal error Fatal error: Uncaught TypeError: count(): Argument #1 ($var) must be of type Countable|array,
There should be some checks for this

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jan 30, 2024

Not needed anymore.

@Jimmi08 Jimmi08 closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: forum type: enhancement An improvement or new feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants